On Mon, 1 May 2000, David S. Miller wrote:
>
> Alexander, there seems to be a problem still with the mntent changes
> in pre7-1. For example, if you create a kernel thread during bootup
> without CLONE_FS, the __copy_fs_struct will barf on the NULL
> rootmnt/root/pwdmnt/pwd members coming from INIT_FS. I actually
> have this happening on Sparc64 with pre7-1 which is how I found
> the problem.
>
> I think to fix this, mntget/mntput should be defined analogously to
> dget/dput in that they just do nothing if the argument is NULL.
Umm... Yes, probably you are right. I'm a bit nervous about going
that way right now - it will just hide some real places where we are
getting NULL by mistake.
OTOH, copy_fs_struct() definitely should not barf on that - I'll add the
checks there. Once I'll be sure that we got the refcounts handling right -
fine with me, mntget(NULL) and mntput(NULL) become no-ops.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sun May 07 2000 - 21:00:11 EST