Re: 2.3.4[89] fail to probe/id IDE properly (long)

From: Tim Coleman (tim@beastor.mine.nu)
Date: Tue Mar 07 2000 - 18:09:15 EST


Message-ID: <20000307164951.A12676@beastor.mine.nu>
References: <Pine.LNX.4.10.10003071118420.7246-100000@home.suse.com> <38C564E0.22DB594F@mandrakesoft.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="+QahgC5+KEYLbs62"
Content-Disposition: inline
User-Agent: Mutt/1.1.4i
In-Reply-To: <38C564E0.22DB594F@mandrakesoft.com>; from jgarzik@mandrakesoft.com on Tue, Mar 07, 2000 at 03:21:52PM -0500
Sender: owner-linux-kernel@vger.rutgers.edu
Precedence: bulk

--+QahgC5+KEYLbs62
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 07, 2000 at 03:21:52PM -0500, Jeff Garzik wrote:
> [snipping]
>=20
> Look at Tim Coleman's latest patch. It appears to address mentioned
> issues, and looks good to me for the 4-5 drivers I manually checked
> against his patch.
>=20

Before you use it, you might want to change this:

---> if [ "$CONFIG_PCI" =3D "y" ]; then
         if [ "$CONFIG_EXPERIMENTAL" =3D "y" ]; then
            tristate ' DM9102 PCI Fast Ethernet Adapter support (EXPERIM=
ENTAL)' CONFIG_DM9102
         fi
      fi

I missed the closing " on "$CONFIG_PCI" in the
patch. I couldn't figure out why it wouldn't
work -- I should have turned on syntax highlighting.

> (as I mentioned in private mail to Andre) Note that pci.h needs to be
> fixed in 2.3.current so that it correctly and fully handles the
> !CONFIG_PCI case. Ideally pci.h should define inline no-op functions
> when !CONFIG_PCI, so that drivers need not test CONFIG_PCI at all
> themselves.

That would be really nice and would fix things like the problem I had on=20
2.3.48 with CONFIG_PCI breaking parport code (?!) I have yet to try=20
anything later.

Tim

--=20
------------------------------------------------------------------------
tim@beastor.mine.nu
Software Developer/Systems Administrator/RDBMS Specialist/Linux Advocate
University of Waterloo Honours Co-op Combinatorics & Optimization
finger tim@beastor.mine.nu for PGP public key ID 0xCB7C7974

--+QahgC5+KEYLbs62
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.1 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE4xXl/aP2t/Mt8eXQRArsVAJ95DAeYW5GTOoREbVQofCEO9aUGMwCfU7zS
7nngEoIloHbCqavoE1RDrqs=
=0f71
-----END PGP SIGNATURE-----

--+QahgC5+KEYLbs62--

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun May 07 2000 - 21:00:11 EST