François romieu wrote:
>
> The Fri, Apr 28, 2000 at 04:56:23PM -0400, Jeff Garzik wrote :
> [...]
> > Looks reasonable... using mod_timer means you only acquire and release
> > the timer lock once, not twice as with del_timer+add_timer.
>
> Yes, but as Doug Ledford has just reminded me, it's gonna break seriously
> with 2.0/2.2 drivers. I happily missed this point.
2.3.x mod_timer is unchanged from 2.2.x.
If you want to worry about 2.0.x, please don't add more cruft to the
tree... put it in something like my kcompat24 module.
> Thus, should I :
> - back port mod_timer to 2.0/2.2 ;
> - add a wrapper for mod_timer in every file supposed to be back-compatible ;
> - forget it until someone brings in a good (TM) solution ?
the only thing I would suggest in addition to your 2.3.x patch is
backporting mod_timer to 2.0.x, and only if you really really want to.
2.0.x is ancient...
Jeff
-- Jeff Garzik | Nothing cures insomnia like the Building 1024 | realization that it's time to get up. MandrakeSoft, Inc. | -- random fortune- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sun Apr 30 2000 - 21:00:16 EST