Re: [PATCH] PCI quirk for VIA ACPI device

From: Jeff Garzik (jgarzik@mandrakesoft.com)
Date: Thu Apr 27 2000 - 20:13:39 EST


Andrey Panin wrote:
>
> Hi all,
>
> this patch (against 2.3.99-pre5) provides PCI quirk for VIA ACPI device (same as for Intel and ALI).
> Also modified PIIX4 and VIA support in /linux/arch/i386/kernel/acpi.c to use ioport
> base address from pci_dev structure.

ACPI works on my Via test systems both with and without ACPI disabled in
BIOS[1]. I'm curious why this quirk is necessary?

Are you ever booting into Windows? I think ACPI needs the attached
patch, and it may positively affect your situation...

        Jeff

[1] net effect: absence or presence of ACPI tables

-- 
Jeff Garzik              | Nothing cures insomnia like the
Building 1024            | realization that it's time to get up.
MandrakeSoft, Inc.       |        -- random fortune

Index: arch/i386/kernel/acpi.c =================================================================== RCS file: /g/cvslan/linux_2_3/arch/i386/kernel/acpi.c,v retrieving revision 1.1.1.17 retrieving revision 1.1.1.17.4.1 diff -u -r1.1.1.17 -r1.1.1.17.4.1 --- arch/i386/kernel/acpi.c 2000/04/26 01:51:29 1.1.1.17 +++ arch/i386/kernel/acpi.c 2000/04/27 00:41:54 1.1.1.17.4.1 @@ -773,6 +773,10 @@ static int __init acpi_probe(struct pci_dev *dev, const struct pci_device_id *id) { + int rc = pci_enable_device (dev); + if (rc) + return rc; + return acpi_chip_info[id->driver_data].chip_init(dev); } @@ -1619,6 +1623,7 @@ int __init acpi_init(void) { struct acpi_facp *facp = NULL; + int rc; if (acpi) acpi_setup(acpi); @@ -1627,12 +1632,12 @@ return -ENODEV; } else if (acpi_opts & ACPI_TABLES_ONLY) { - if (acpi_find_tables()) - return -ENODEV; + rc = acpi_find_tables(); + if (rc) return rc; } else if (acpi_opts & ACPI_CHIPSET_ONLY) { - if (acpi_find_chipset()) - return -ENODEV; + int rc = acpi_find_chipset(); + if (rc) return rc; } else { switch (acpi_find_tables()) {

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Apr 30 2000 - 21:00:14 EST