Re: Update to serial driver for Linux 2.3.99pre6-6

From: Theodore Ts'o (
Date: Thu Apr 27 2000 - 16:45:50 EST

   Date: Wed, 26 Apr 2000 01:51:50 +0000
   From: Albert Cranford <> wrote:
> Patch generated: on Tue Apr 25 22:52:46 EDT 2000 by
> against Linux version 2.3.99
> info->port = state->port;
> + info->port += state->port_high << HIGH_BITS_OFFSET;

   I had to change this to:
    info->port += state->port << HIGH_BITS_OFFSET;
   to get a clean compile. There is no member port_high in

The lines should just be deleted, since they're not needed. state->port
is already 64 bits, which is why there is no high bits offset. (That's
just there because I needed to maintain backwards compatibilty with the
exported ioctl interface. But struct serial_state is an internal
structure, so it stores the port information in the native format.)

The reason why I didn't notice this before I submitted the patch was
that apparently egcs was optimizing it out so completely that it wasn't
even issuing an error that I was referencing an invalid structure
member. (When I first figured that out, it was a "WTF?" moment.)

Linus, I'll submit to you an updated patch versus pre6-7.

                                                - Ted

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
Please read the FAQ at

This archive was generated by hypermail 2b29 : Sun Apr 30 2000 - 21:00:13 EST