Re: Linux Jobs as of 2.3.99pre6-5

From: Bill Wendling (wendling@ganymede.isdn.uiuc.edu)
Date: Tue Apr 25 2000 - 16:48:40 EST


Also sprach Jeff Garzik:
}
} Does the attached patch look ok to everyone?
}
} +
} + if (drv->exclude_table) {
} + const struct pci_device_id *exclude =
} + pci_match_device(drv->exclude_table, dev);
} + if (exclude)
} + return 0;
} + }
} +
Why assign it to a variable which is never used again? You could test the
output of pci_match_device in the if() statement :o)

-- 
|| Bill Wendling			wendling@ganymede.isdn.uiuc.edu

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Apr 30 2000 - 21:00:10 EST