Re: [PATCH] KERNEL_VERSION

From: Brian Gerst (bgerst@quark.vpplus.com)
Date: Sun Apr 23 2000 - 18:35:11 EST


Jeff Garzik wrote:
>
> Philipp Matthias Hahn wrote:
> > There are several macros like
> > - CVT_LINUX_VERSION
> > - ASC_LINUX_VERSION
> > - KERNEL_VER
> > - LINUXVERSION,
> > - LinuxVersionCode
> > - ibmmca_header_linux_version
> > - local_LinuxVersionCode
> > which all do the same thing as KERNEL_VERSION.
> > LINUX_KERNEL_VERSION was compared agains values in hex, dec and the above.
> >
> > A patch for 2.3.99-pre5 changing all to KERNEL_VERSION is available at
> > http://www.lahn.de/~titan/prog/kernel_version.diff.gz
>
> Patch looks good.
>
> My only comment is that, from reading other compat code, it seems that
> KERNEL_VERSION macro might not be universally available... Code which
> wants to be compatible with older code would probably need an 'ifndef
> KERNEL_VERSION' construct at the beginning.

KERNEL_VERSION was introduced somewhere aroune 2.1.95. I submitted a
similar patch before but it got shot down because it was a large change
for only a cosmetic benefit. I have been working on a set of pruning
patches that pull out code for kernels earlier that 2.2. Once that
cruft is gone, then we can convert the remaining ones to KERNEL_VERSION
with less impact.

-- 

Brian Gerst

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Apr 23 2000 - 21:00:22 EST