Re: [PATCH] f_op->poll() without lock_kernel()

From: Jamie Lokier (lfs@tantalophile.demon.co.uk)
Date: Sat Apr 22 2000 - 10:57:41 EST


Alexander Viro wrote:
> > I think poll_pq should be renamed to pq_poll, so that it uses a naming
> > convention in sync with what everyone else does.

Note also read_mem in mem.c, etc.

> What _should_ be done is the conversion of initializers to new syntax.

Fwiw, you can check you haven't missed any initialisers by redeclaring
the *_ops types with a bunch of extra function pointers with implausible
types at the beginning. I've noticed that some new outside-the-tree
drivers are still being written using the old initialiser syntax, so it
might be worthwhile to have a way to check them as they migrate into the
tree.

Fwiw#2, you can check you did the conversions correctly easily enough --
the binary images should be identical.

-- Jamie

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Apr 23 2000 - 21:00:20 EST