Re: [PATCH] f_op->poll() without lock_kernel()

From: David S. Miller (davem@redhat.com)
Date: Fri Apr 21 2000 - 16:53:59 EST


   Date: Fri, 21 Apr 2000 23:49:45 +0200
   From: Manfred Spraul <manfreds@colorfullife.com>

   How did you grep? You missed

   drivers/char/qpmouse.c:
           poll_pq() looks good, but read_qp() needs lock_kernel.
           [while(!queue_empty()) { get_from_queue()} ]

I used "*_poll", and filtered out the noise by hand.

I think poll_pq should be renamed to pq_poll, so that it uses a naming
convention in sync with what everyone else does.

Later,
David S. Miller
davem@redhat.com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Apr 23 2000 - 21:00:19 EST