Andrea Arcangeli wrote:
>
> So far I only had a very superficial look to the old implementation and I
> noticed probably this was wrong in the old implementation:
>
> *start = page + (begin-off);
>
> I need a good sleep now :), more thoughts on the above line next morning.
>
the variables are wrong way around: it must be "off-begin"
begin can be 0, and off 1.
just try
dd if=some_serial_proc_entry bs=1
it prints garbage.
It seems that most tty implementations copied the wrong line, just grep
for "begin-off" (fs/proc/proc_tty.c, and some serial drivers).
-- Manfred- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sun Apr 23 2000 - 21:00:16 EST