[PATCH] FASYNC failure return.

• Next message: Rusty Russell: "[PATCH] Remove 200 bogus `unused' warnings."
• Previous message: bug1: "ide_dma_timeout func only:14 and 13 when reading heavily"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Linus, please apply.

ioctl(FASYNC) should fail on fds that don't support it, or when it
doesn't work.

--- linux-2.3/fs/ioctl.c.~1~ Tue Nov 30 17:57:44 1999
+++ linux-2.3/fs/ioctl.c Tue Dec 21 14:10:54 1999
@@ -91,8 +91,12 @@
                         /* Did FASYNC state change ? */
                         if ((flag ^ filp->f_flags) & FASYNC) {
                                 if (filp->f_op && filp->f_op->fasync)
- filp->f_op->fasync(fd, filp, on);
+ error = filp->f_op->fasync(fd, filp, on);
+ else error = -ENOTTY;
                         }
+ if (error != 0)
+ break;
+
                         if (on)
                                 filp->f_flags |= FASYNC;
                         else

--
Hacking time.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Rusty Russell: "[PATCH] Remove 200 bogus `unused' warnings."
• Previous message: bug1: "ide_dma_timeout func only:14 and 13 when reading heavily"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Apr 23 2000 - 21:00:14 EST