Re: What to do with 3c59x.c?

From: Andrew Morton (andrewm@uow.edu.au)
Date: Wed Apr 12 2000 - 08:09:10 EST


Jeff Garzik wrote:
>
> Andrew Morton wrote:
> > - The consensus here seems to be that I should continue to generate
> > drivers/net/3c59x.o as well as drivers/net/pcmcia/3c575_cb.o. Fair
> > enough.
>
> The stumbling block seems to be pcmcia. If we can get pcmcia to load
> 3c59x.o for all its 3com needs, then there should be no reason why
> 3c575_cb.o continues to live.

Yes, the pcmcia scripts can be persuaded to do this. You tell them the
path to the 3c575 driver module is "net/3c59x" and it finds it:

device "3c575_cb"
  class "network" module "cb_enabler", "net/3c59x"

But David is concerned that this will require everyone to upgrade their
pcmcia config.

> > - I don't want to copy a single .o file into two places because the
> > source _should_ be compiled twice.
>
> What makes you think this? The source should not need to be compiled
> twice. The PCI driver interface is designed to seamlessly support
> hotplug and non-hotplug.

Well, at present this driver supports EISA, PCI and cardbus. But it
_used_ to have a couple of #ifdef CARDBUS conditionals in it. I have
removed these, deferring the decision to runtime.

If there is a future need to employ #ifdef CARDBUS then 3c59x.o and
3c575_cb.o will be different, even though the source is the same. I
don't think this option should be discarded.

Any opinions, David?

-- 
-akpm-

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Apr 15 2000 - 21:00:18 EST