[FIX] Re: 2.3.99-4 oops

From: Alexander Viro (viro@math.psu.edu)
Date: Tue Apr 11 2000 - 18:26:42 EST


On Tue, 11 Apr 2000, Alexander Viro wrote:

> On Tue, 11 Apr 2000, Borislav Deianov wrote:
>
> > Hi,
> >
> > The freshly downloaded 2.3.99-4 is quite unhappy here, very reliable
> > OOPS in init immediately after boot:
>
> D'oh. In open_namei() dentry got piece of name ("/dev/console", right?)
> instead of ->d_inode. Total BS - if it's indeed /dev/console, we shouldn't
> be creating anything, so that's pure lookup path. Hmm... .config?

And BS it was - on my part ;-/
diff -urN linux-2.3.99-pre4/fs/namei.c linux-bird.vfs/fs/namei.c
--- linux-2.3.99-pre4/fs/namei.c Tue Apr 11 18:09:48 2000
+++ linux-bird.vfs/fs/namei.c Tue Apr 11 19:17:37 2000
@@ -522,7 +522,7 @@
 walk_init_root(const char *name, unsigned flags, struct nameidata *nd)
 {
        if (current->personality != PER_LINUX)
- if (__emul_lookup_dentry(name,flags,nd));
+ if (__emul_lookup_dentry(name,flags,nd))
                        return 0;
        nd->mnt = mntget(current->fs->rootmnt);
        nd->dentry = dget(current->fs->root);

Modulo that it seems to be OK (== boots and seems to work). Linus, apply
it please. And could you pass one of these paperbags?
                                                        Cheers,
                                                                Al

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Apr 15 2000 - 21:00:17 EST