On Mon, Apr 10, 2000 at 07:59:36PM -0300, Garst R. Reese wrote:
> Alexander Viro wrote:
> >
> > On Mon, 10 Apr 2000, Garst R. Reese wrote:
> >
> > > Hi Mike and Al
> > > Attached is the relevant part of my make.log from recompiling
> > > alsa-driver-0.5.7 with
> > > Alexander's suggested change to kernel/info.c
> > > Seems to work ok though.
> >
> > Arrgh. I plead lack of caffein - vfs_follow_link(nd,tmp), indeed.
> > The only reason why it "worked" for you is that you didn't try to follow
> > any relevant links - otherwise it would crash. Badly.
> looks better, new make.log attached.
> Thanks
> Garst
> make[1]: Entering directory `/usr/local/src/alsa/alsa-driver-0.5.7/kernel'
> gcc -DALSA_BUILD -D__KERNEL__ -O2 -m486 -malign-loops=2 -malign-jumps=2 -malign-functions=2 -DCPU=586 -DLINUX -Wall -Wstrict-prototypes -fomit-frame-pointer -pipe -I/usr/src/linux/include -I.. -c -o info.o info.c
> info.c: In function `snd_info_card_followlink':
> info.c:607: warning: return makes integer from pointer without a cast
>
> ALSA modules were sucessfully compiled.
>
I tried to build the latest CVS version of alsa and I dies in kernel/info.c
.
I didn't follow the thread but I think that there is something related with
my problem too.
As I've seen the number of arguments of lookup_dentry has changed from 3 to
2.
static struct dentry *snd_info_card_followlink(struct dentry *dentry,
struct dentry *base,
unsigned int follow)
{
snd_card_t *card;
char tmp[16];
down(&info_mutex);
card = snd_info_find_card(dentry->d_inode->i_ino);
if (card == NULL || card->proc_dir == NULL) {
up(&info_mutex);
return NULL;
}
strcpy(tmp, card->id);
up(&info_mutex);
return lookup_dentry(tmp, base, follow);
}
Can you tell me how should I change the return line(I tried:
lookup_dentry(tmp, follow | LOOKUP_POSITIVE)
but it didn't work)?
-- Mircea Damian E-mails: dmircea@kappa.ro, dmircea@roedu.net WebPage: http://taz.mania.k.ro/~dmircea/- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sat Apr 15 2000 - 21:00:16 EST