Dragan Stancevic wrote:
>
> This patch is for 2.2 kernels against Andrey's "1.20.2.4" driver located at
> ftp://ftp.sw.com.sg/pub/Linux/people/saw/kernel/v2.2/, this patch provides
> a bit more detailed information about installed devices.
hmmm.
* kmalloc'ing the product name is completely unnecessary in this patch,
it is never used outside of the routine in which the kmalloc occurs
* you should be passing the ethernet device name to request_region. you
can easily overflow a buffer (at least in 2.3.x, maybe in 2.2.x too) if
you pass a too-long name to request_region. further, some userland
software depends on the ethernet interface name being the value passed
to request_region.
* can you get any of this info out of subsystem-device/vendor-id?
* instead of passing _yet another_ pci device structure member as an
argument to speedo_found1, why not just convert the driver to use the
new pci_dev structure. using pcibios_xxx is deprecated under 2.2.x, and
requires use of the slow pci_find_slot function to compensate. Making
this conversion also brings the 2.2.x and 2.3.x eepro100 drivers closer
together.
-- Jeff Garzik | Tact is the ability to tell a man Building 1024 | he has an open mind when he has a MandrakeSoft, Inc. | hole in his head. (-random fortune)- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Fri Mar 31 2000 - 21:00:28 EST