Re: [PATCH] tulip hosed in pre3-3

From: Jeff Garzik (jgarzik@mandrakesoft.com)
Date: Tue Mar 21 2000 - 00:25:16 EST


Paul Laufer wrote:
>
> On 20 Mar 2000, Michael Harnois wrote:
>
> > --- drivers/net/tulip/tulip.h.orig Mon Mar 20 15:56:05 2000
> > +++ drivers/net/tulip/tulip.h Mon Mar 20 15:54:53 2000
> > @@ -17,6 +17,7 @@
> > #include <linux/spinlock.h>
> > #include <linux/netdevice.h>
> > #include <linux/timer.h>
> > +#include <asm/io.h>
> >
> > struct tulip_chip_table {
> > char *chip_name;
> >
> > --
> > Michael D. Harnois, Redeemer Lutheran Church, Washburn, IA
> > mdharnois@home.com aa0bt@aa0bt.ampr.org
> > Be radical, be as radical as you can ...
> > because radicals empower liberals.
> > --John Preston
> >
>
> If you do this, you might as well remove the #include <asm/io.h> from
> files that #include "tulip.h". Unless there is a good reason to not do so?
>
> Patch attached.

looks good to me, applied locally... will test tomorrow along with a
few other things.

        Jeff

>
> Paul Laufer
>
> ------------------------------------------------------------------------
> Name: tulip.99pre3-3.patch
> tulip.99pre3-3.patch Type: Plain Text (TEXT/PLAIN)
> Encoding: BASE64

-- 
Jeff Garzik              | Tact is the ability to tell a man 
Building 1024            | he has an open mind when he has a
MandrakeSoft, Inc.       | hole in his head.  (-random fortune)

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Mar 23 2000 - 21:00:31 EST