[PATCH] 2.3.99-pre1 spurious put_filesystem in super.c:read_super()

• Next message: Manfred Spraul: "Re: (reiserfs) reiserfs and knfsd and NFSv4 and volatile file handles"
• Previous message: David Hinds: "Re: PCMCIA broken, many issues"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi,

--- fs/super.c.old Fri Mar 17 22:41:34 2000
+++ fs/super.c Fri Mar 17 22:42:30 2000
@@ -606,7 +606,6 @@
         s->s_dev = 0;
         s->s_bdev = 0;
         s->s_type = NULL;
- put_filesystem(type);
         unlock_super(s);
         return NULL;
 }

The call to put_filesystem() in read_super() is wrong - all read_super()'s
callers call put_filesystem() if read_super() fails. As the callers inc the
use count, it seems reasonable that they are responsible for dec'ing it.

-- 
Horses are forbidden to eat fire hydrants in Marshalltown, Iowa.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Manfred Spraul: "Re: (reiserfs) reiserfs and knfsd and NFSv4 and volatile file handles"
• Previous message: David Hinds: "Re: PCMCIA broken, many issues"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Mar 23 2000 - 21:00:24 EST