"Sean Hunter" <sean@uncarved.co.uk> said:
[...]
> diff -ur linux/drivers/video/fbmem.c linux.patched/drivers/video/fbmem.c
> --- linux/drivers/video/fbmem.c Wed Mar 8 22:00:08 2000
> +++ linux.patched/drivers/video/fbmem.c Mon Mar 13 22:26:27 2000
> @@ -418,10 +418,13 @@
> int fbidx = GET_FB_IDX(file->f_dentry->d_inode->i_rdev);
> struct fb_info *info = registered_fb[fbidx];
> struct fb_ops *fb = info->fbops;
> + unsigned long off;
> +#if !defined(__sparc__) || defined(__sparc_v9__)
> struct fb_fix_screeninfo fix;
> struct fb_var_screeninfo var;
> - unsigned long start, off;
> + unsigned long start;
> u32 len;
> +#endif
Isn't there a more sane condition for this #if? Or add an
__attribute__((unused)) to the offending variable(s) as needed.
> diff -ur linux/fs/nfs/read.c linux.patched/fs/nfs/read.c
> --- linux/fs/nfs/read.c Sat Nov 27 23:51:32 1999
> +++ linux.patched/fs/nfs/read.c Mon Mar 13 22:12:11 2000
> @@ -234,7 +234,7 @@
>
> lock_kernel();
> dprintk("NFS: nfs_readpage (%p %ld@%lu)\n",
> - page, PAGE_SIZE, page->index);
> + page, (long)PAGE_SIZE, page->index);
Why not fix the format here and in the next ones? Or fix the #definition of
PAGE_SIZE to a long constant, if done for the other arches?
(No criticism intended, this kind of work is needed and much
appreciated. Thanks!)
-- Dr. Horst H. von Brand mailto:vonbrand@inf.utfsm.cl Departamento de Informatica Fono: +56 32 654431 Universidad Tecnica Federico Santa Maria +56 32 654239 Casilla 110-V, Valparaiso, Chile Fax: +56 32 797513- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Wed Mar 15 2000 - 21:00:29 EST