[2.3.52-pre2] compile error: ppp_synctty.c

From: Peter Blomgren (blomgren@monster.stanford.edu)
Date: Mon Mar 13 2000 - 15:08:52 EST


Hi,

=== THE ERROR ===

gcc -D__KERNEL__ -I/usr/src/linux/include -D__SMP__ -Wall -Wstrict-prototypes \
   -O2 -fomit-frame-pointer -pipe -m386 -DCPU=386 -fno-strict-aliasing \
   -DMODULE -DMODVERSIONS -include /usr/src/linux/include/linux/modversions.h \
   -c -o ppp_synctty.o ppp_synctty.c
ppp_synctty.c: In function `ppp_sync_ioctl':
ppp_synctty.c:442: too many arguments to function `ppp_register_channel_Rsmp_b7511e1b'

=== THE CODE ===

The relevant chunk of code (drivers/net/ppp_synctty.c, lines 434-446)

        case PPPIOCATTACH:
                if (get_user(val, (int *) arg))
                        break;
                err = -EALREADY;
                if (ap->connected)
                        break;
                ap->chan.private = ap;
                ap->chan.ops = &sync_ops;
-> err = ppp_register_channel(&ap->chan, val);
                if (err != 0)
                        break;
                ap->connected = 1;
                break;

=== THE PATCH ===

The following patch fixes the compilation error (tested), buy may not
be correct since "val" was supposed to be used for something???

--- linux/drivers/net/ppp_synctty.c.orig Mon Mar 13 11:43:41 2000
+++ linux/drivers/net/ppp_synctty.c Mon Mar 13 11:43:57 2000
@@ -439,7 +439,7 @@ ppp_sync_ioctl(struct tty_struct *tty, s
                         break;
                 ap->chan.private = ap;
                 ap->chan.ops = &sync_ops;
- err = ppp_register_channel(&ap->chan, val);
+ err = ppp_register_channel(&ap->chan);
                 if (err != 0)
                         break;
                 ap->connected = 1;

-- 
\Peter.

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Mar 15 2000 - 21:00:25 EST