On Mon, 13 Mar 2000, Petr Vandrovec wrote:
> On 13 Mar 00 at 8:29, Geert Uytterhoeven wrote:
> > This patch removes the compatibility cruft which was supposed to go away in
> > 2.4.0. I guess I can send it to Linus, or does anyone still sees some bugs
> > running around?
> > --- native-2.3.51/include/linux/fb.h Sat Mar 11 15:34:26 2000
> > +++ linux/include/linux/fb.h Sun Mar 12 16:19:16 2000
> > @@ -232,11 +232,7 @@
> > -#if 1 /* to go away in 2.4.0 */
> > -extern int GET_FB_IDX(kdev_t rdev);
> > -#else
> > #define GET_FB_IDX(node) (MINOR(node))
> > -#endif
> Well, maybe that it is just me, but I can say something, I think
> that we should left this code here for whole 2.4.x, as I still sometime
> run 2.3.x together with 2.2.x and unless I switch to devfs, I must
> have /dev/fb1 pointing to 29,32; but to 29,1 for 2.[34].x. I think
> that it is unacceptable.
You have a point here... I'll change the comment from 2.4.0 to 2.5.0 if you all
agree.
> I think that we should revert all fbcon/fbmem changes that went into
> 2.3.51 (video= -> fbcon=; change in initialization order (white
I've been considering this as well during the weekend. Linus' pre-2.4.0 came
rather unexpected, so we don't have time anymore to cut the rough edges.
James: do you agree?
> square on matroxfb); video4linux (in)compatibility). I received
The video4linux case is very disputable: opening a hardware device twice is bad
practice. You're not allowed to do that with e.g. audio neither.
> couple of bugreports on these topics during weekend :-(
And so did I (for atyfb). Sidenote: life is sometimes much more easy on
non-ia32, where atyfb keeps on working fine...
So for 2.4.0, I think we should focus only on
- Updated vfb, so new drivers do things well. I suggest to add a warning to
the top of vfb that _new_ drivers not complying to the new rules will not
be accepted (and I'll enforce this by asking Linus to remove any _new_
drivers that don't).
- Updated other fbdev (cfr. vfb), if possible
- Clean ups and bug fixes
What do you think?
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven ------------- Sony Software Development Center Europe (SDCE) Geert.Uytterhoeven@sonycom.com ------------------- Sint-Stevens-Woluwestraat 55 Voice +32-2-7248638 Fax +32-2-7262686 ---------------- B-1130 Brussels, Belgium- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Wed Mar 15 2000 - 21:00:24 EST