Re: drivers/net/Config.in cleanup

From: Riley Williams (rhw@MemAlpha.cx)
Date: Sun Mar 12 2000 - 18:32:56 EST


Hi Tim.

> As well, I wasn't aware that you could not define the same
> CONFIG_ option twice. I have now been told as much. :)
>
> Since the (suggested) problem has to do with CONFIG_PCI,
> those cards which explicitly require PCI can have

> if [ "$CONFIG_PCI" = "y" ]; then

> wrapped around them, and the others can be left as is.

> I sent another mail to that effect on the list early this
> afternoon.

I have to admit that I'd like to see this particular config
section really cleaned up, as the current collection of options
presented is far too confusing for what is really a fairly simple
configuration criteria.

My rewrite is enclosed - I tried diff'ing it, but the result is
nearly 2.5 times the size of the raw file, hence my enclosing the
raw file as proposed...

One thing though: It used to be the case that xconfig could only
handle test of the "$var" = "x" variety, and also could only
handle one variable per condition. Unless this has changed, most
of the tests in the current version of this file are broken. I've
rewritten all the tests in the format xconfig is known to be able
to handle in this version, although in a few cases, this has
increased the number of levels of if statements...

Best wishes from Riley.

 * Copyright (C) 2000, Memory Alpha Systems.
 * All rights and wrongs reserved.

+----------------------------------------------------------------------+
| There is something frustrating about the quality and speed of Linux |
| development, ie., the quality is too high and the speed is too high, |
| in other words, I can implement this XXXX feature, but I bet someone |
| else has already done so and is just about to release their patch. |
+----------------------------------------------------------------------+
 * http://www.memalpha.cx/Linux/Kernel/



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Mar 15 2000 - 21:00:23 EST