return value of *_setup() (was: Re: speaking of 2.3.x diff........)

From: Geert Uytterhoeven (Geert.Uytterhoeven@sonycom.com)
Date: Fri Mar 10 2000 - 08:09:40 EST

On Fri, 10 Mar 2000, Jouko Pynnonen wrote:
> Btw, i think there's a bug or feature in drivers/fbmem.c where it parses
> 'video=' kind of kernel options. It always returns 0 so the video options
> get passed to the init process as an environment variable... it still gets
> parsed right so it doesn't have any effect.

Aha, so the return values do matter?

<reading parse_options() and checksetup()>

Yes, *_setup() functions must return 1 if they accepted the arguments.

video_setup() indeed always returns 0. I checked some other drivers, and at
least parse_ide_setup() does as well.

Gr{oetje,eeting}s,

                                                Geert 

--
Geert Uytterhoeven ------------- Sony Software Development Center Europe (SDCE)
Geert.Uytterhoeven@sonycom.com ------------------- Sint-Stevens-Woluwestraat 55
Voice +32-2-7248638 Fax +32-2-7262686 ---------------- B-1130 Brussels, Belgium

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Wed Mar 15 2000 - 21:00:17 EST