Re: 2.3.4[89] fail to probe/id IDE properly (long)

From: Tim Coleman (tim@beastor.mine.nu)
Date: Tue Mar 07 2000 - 12:14:49 EST


On Tue, Mar 07, 2000 at 05:50:10PM +0100, Andrzej Krzysztofowicz wrote:
>
> > Wouldn't it make more sense to separate it into separate chunks
> > i.e. CONFIG_NET_PCI, CONFIG_NET_EISA, CONFIG_NET_VLB, CONFIG_NET_ONBOARD
> > and *then* check for CONFIG_PCI before offering CONFIG_NET_PCI?
> >
> > Or maybe I'm just completely clueless.

> How the common driver should be compiled if you answer "y" to the first and
> "m" (or even "n") to the second ?
>
> IMHO, it should be enough (and be a good way) to make dependent on
> CONFIG_PCI just the drivers which support *ONLY* PCI cards,
> eg: Tulip, PCI NE2000, RTL-8139...

You're right, I am clueless :)

I think that would be the only proper way to do it. You could just
wrap [ "$CONFIG_PCI" = "y" ] around the PCI only cards.

------------------
--- Config.in Tue Mar 7 12:03:43 2000
+++ Config.in.new Tue Mar 7 12:11:15 2000
@@ -122,8 +122,10 @@
    bool ' EISA, VLB, PCI and on board controllers' CONFIG_NET_PCI
    if [ "$CONFIG_NET_PCI" = "y" ]; then
       tristate ' AMD PCnet32 (VLB and PCI) support' CONFIG_PCNET32
- if [ "$CONFIG_EXPERIMENTAL" = "y" ]; then
- tristate ' Adaptec Starfire support (EXPERIMENTAL)' CONFIG_ADAPTEC_STARFIRE
+ if [ "$CONFIG_PCI" = "y"]; then
+ if [ "$CONFIG_EXPERIMENTAL" = "y" ]; then
+ tristate ' Adaptec Starfire support (EXPERIMENTAL)' CONFIG_ADAPTEC_STARFIRE
+ fi
       fi
       if [ "$CONFIG_EXPERIMENTAL" = "y" ]; then
          tristate ' Ansel Communications EISA 3200 support (EXPERIMENTAL)' CONFIG_AC3200
@@ -134,28 +136,38 @@
          tristate ' CS89x0 support' CONFIG_CS89x0
       fi
       tristate ' Generic DECchip & DIGITAL EtherWORKS PCI/EISA' CONFIG_DE4X5
- tristate ' DECchip Tulip (dc21x4x) PCI support' CONFIG_TULIP
+ if [ "$CONFIG_PCI" = "y" ]; then
+ tristate ' DECchip Tulip (dc21x4x) PCI support' CONFIG_TULIP
+ fi
       tristate ' Digi Intl. RightSwitch SE-X support' CONFIG_DGRS
- if [ "$CONFIG_EXPERIMENTAL" = "y" ]; then
- tristate ' DM9102 PCI Fast Ethernet Adapter support (EXPERIMENTAL)' CONFIG_DM9102
+ if [ "$CONFIG_PCI = "y" ]; then
+ if [ "$CONFIG_EXPERIMENTAL" = "y" ]; then
+ tristate ' DM9102 PCI Fast Ethernet Adapter support (EXPERIMENTAL)' CONFIG_DM9102
+ fi
+ fi
+ if [ "$CONFIG_PCI" = "y" ]; then
+ tristate ' EtherExpressPro/100 support' CONFIG_EEPRO100
+ if [ "$CONFIG_EXPERIMENTAL" = "y" ]; then
+ if [ "$CONFIG_EEPRO100" = "y" -o "$CONFIG_EEPRO100" = "m" ]; then
+ bool ' Enable Power Management (EXPERIMENTAL)' CONFIG_EEPRO100_PM
+ fi
+ fi
       fi
- tristate ' EtherExpressPro/100 support' CONFIG_EEPRO100
       if [ "$CONFIG_EXPERIMENTAL" = "y" ]; then
- if [ "$CONFIG_EEPRO100" = "y" -o "$CONFIG_EEPRO100" = "m" ]; then
- bool ' Enable Power Management (EXPERIMENTAL)' CONFIG_EEPRO100_PM
- fi
- tristate ' Mylex EISA LNE390A/B support (EXPERIMENTAL)' CONFIG_LNE390
- tristate ' Novell/Eagle/Microdyne NE3210 EISA support (EXPERIMENTAL)' CONFIG_NE3210
+ tristate ' Mylex EISA LNE390A/B support (EXPERIMENTAL)' CONFIG_LNE390
+ tristate ' Novell/Eagle/Microdyne NE3210 EISA support (EXPERIMENTAL)' CONFIG_NE3210
       fi
- tristate ' PCI NE2000 support' CONFIG_NE2K_PCI
+ if [ "$CONFIG_PCI" = "y" ]; then
+ tristate ' PCI NE2000 support' CONFIG_NE2K_PCI
+ if [ "$CONFIG_EXPERIMENTAL" = "y" ]; then
+ tristate ' RealTek 8129 (not 8019/8029!) support (EXPERIMENTAL)' CONFIG_RTL8129
+ fi
       # tristate ' Sundance Alta support' CONFIG_ALTA
- if [ "$CONFIG_EXPERIMENTAL" = "y" ]; then
- tristate ' RealTek 8129 (not 8019/8029!) support (EXPERIMENTAL)' CONFIG_RTL8129
+ tristate ' RealTek RTL-8139 PCI Fast Ethernet Adapter support' CONFIG_8139TOO
+ tristate ' SiS 900/7016 PCI Fast Ethernet Adapter support' CONFIG_SIS900
+ tristate ' TI ThunderLAN support' CONFIG_TLAN
+ tristate ' VIA Rhine support' CONFIG_VIA_RHINE
       fi
- tristate ' RealTek RTL-8139 PCI Fast Ethernet Adapter support' CONFIG_8139TOO
- tristate ' SiS 900/7016 PCI Fast Ethernet Adapter support' CONFIG_SIS900
- tristate ' TI ThunderLAN support' CONFIG_TLAN
- tristate ' VIA Rhine support' CONFIG_VIA_RHINE
       if [ "$CONFIG_EXPERIMENTAL" = "y" ]; then
          tristate ' Racal-Interlan EISA ES3210 support (EXPERIMENTAL)' CONFIG_ES3210
          tristate ' SMC EtherPower II (EXPERIMENTAL)' CONFIG_EPIC100

---------------------

Tim

-- 
------------------------------------------------------------------------
tim@beastor.mine.nu
Software Developer/Systems Administrator/RDBMS Specialist/Linux Advocate
University of Waterloo Honours Co-op Combinatorics & Optimization
finger tim@beastor.mine.nu for PGP public key ID 0xCB7C7974


- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Mar 07 2000 - 21:00:23 EST