Re: struct packet_type.func() prototype

• Next message: Johannes Erdfelt: "Re: [linux-usb] Re: Irq context wrong for USB ACM serial driver calling PPP?"
• Previous message: Werner Almesberger: "Re: bug: mount on an open directory succeeds"
• In reply to: Jan Kasprzak: "struct packet_type.func() prototype"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

>
> int (*func) (struct sk_buff *, struct net_device *, struct packet_type *);
>
> The first question is - what is this function expected to return?

Unused. I'd not actually noticed that but yes it probably should get turned
void.

> And the second one: What is the third parameter for? It seems it is
> always called with the struct packet_type * corresponding to
> skb->protocol. Syncppp and ipv4 do not use this parameter (according
> to quick look at the source code, I might have missed something).

Sometimes you have several users of the same buffer and you need to know
which instances you are (look at sock_packet)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Johannes Erdfelt: "Re: [linux-usb] Re: Irq context wrong for USB ACM serial driver calling PPP?"
• Previous message: Werner Almesberger: "Re: bug: mount on an open directory succeeds"
• In reply to: Jan Kasprzak: "struct packet_type.func() prototype"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Tue Mar 07 2000 - 21:00:22 EST