Re: Irq context wrong for USB ACM serial driver calling PPP?

From: Jamie Lokier (lu@tantalophile.demon.co.uk)
Date: Mon Mar 06 2000 - 19:30:35 EST


Alan Cox wrote:
> > Are you saying that the line discipline's write_wakeup should be a
> > simple function to queue the line discipline's BH (that's what "wakeup"
> > means to me), or that write_wakeup must be called from BH context by the
> > serial driver?
>
> Take a look at the transmit interrupt handling in the serial.c code. The
> irq code polls the THRE bit and if it indicates room it stuffs bytes down
> the pipe
>
> If the internal buffer is empty it wakes up a task queue on tq_serial. The
> bh context code calls the ldisc wakeup

I wasn't asking what serial.c does, I was asking if the line
disciplines are allowed to assume they'll always be called that way :-)

- Jamie

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Mar 07 2000 - 21:00:21 EST