Re: SMBFS: recvmsg called within BH (was: Re: One more boobytrap needed for 2.2.15pre ?)

From: Michael H. Warfield (mhw@wittsend.com)
Date: Mon Mar 06 2000 - 22:41:22 EST


On Mon, Feb 28, 2000 at 03:44:46PM -0300, Elvis Pfützenreuter wrote:
> > * samba servers use SMB packet "0x85" for keepalive probes. If the
> > client answers, then the connection remains active. smbfs supports these
> > probes.

> > * WinNT servers do not send such packets. They just disconnect after a
> > few minutes (*), and it expects that the client will establish a new
> > connection.

> > smbfs doesn't create a new connection, and the old connection got killed
> > --> io error!

> AFAIK it is smbmount's (user space process) responsability to recreate the
> connection and pass the fd to kernel via ioctl() call. See that smbmount stays
> in memory after successful mouting.

        This is correct.

> The problem is that smbmount has a bug: it closes a log FILE* handle when
> the first connection has been done and, when it tries to remake the
> connection, tries to write some log message again and segfaults.

        This was fixed. If you are using the latest smbmount (it has
mount compatible options like "-o user=foo", etc, etc) it SHOULD not
be having these problems.

> The solution is simple: patch the debug library routine so it tests the file
> handle before tries to printf on it. Since it is not a kernel issue, I did not
> include the patch here, altrough I can send to everyone that asks for it.

        Patch against what version? If there is something remaining in
the smbmount code that Tridge or I missed, by all means send me the patch
and I'll make sure it gets into the samba CVS.

        Mike

-- 
 Michael H. Warfield    |  (770) 985-6132   |  mhw@WittsEnd.com
  (The Mad Wizard)      |  (770) 331-2437   |  http://www.wittsend.com/mhw/
  NIC whois:  MHW9      |  An optimist believes we live in the best of all
 PGP Key: 0xDF1DD471    |  possible worlds.  A pessimist is sure of it!

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Mar 07 2000 - 21:00:21 EST