Re: Irq context wrong for USB ACM serial driver calling PPP?

From: Vojtech Pavlik (vojtech@suse.cz)
Date: Mon Mar 06 2000 - 12:57:06 EST


On Mon, Mar 06, 2000 at 06:54:55PM +0100, Jamie Lokier wrote:

> I agree it's a good idea to change USB ACM. Probably the USB serial
> driver needs to be changed too.

Ok, I can change it. What function I should call from a bh (or tasklet)
instead of an USB callback (interrupt) context?

> It's nasty that you have to find this in PPP -- the USB ACM driver is
> just a fancy serial driver and shouldn't have to know about PPP to get
> right the undocumented details of which functions can be called in which
> contexts.
>
> I wouldn't be surprised if there are other serial drivers with the same
> bug, but nobody noticed. Or arguably it's a bug in PPP. I'd really
> whoever designed the tty layer to define what each side of the interface
> may assume.

Ask Ted Ts'o ...

-- 
Vojtech Pavlik
SuSE Labs

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Mar 07 2000 - 21:00:20 EST