Jeff Garzik wrote:
> Paul Vojta wrote:
> > I looked through acpi.c, and it seems to me that ACPI power-off support
> > has not yet been written for linux.
>
> That's funny, when I install acpid, power-off works great for me.
If the feature requires additional support, then that fact should be
documented in Documentation/Configure.help (as is the case with CONFIG_APM).
> > If so, then it seems to me that the
> > appropriate patch would be something like:
> >
> > --- arch/i386/config.in Sun Feb 20 20:37:09 2000
> > +++ arch/i386/config.in.new Sat Mar 4 13:06:17 2000
> > @@ -141,7 +141,7 @@
> >
> > source drivers/parport/Config.in
> >
> > -bool 'ACPI support' CONFIG_ACPI
> > +bool 'ACPI support (EXPERIMENTAL)' CONFIG_ACPI
> > if [ "$CONFIG_ACPI" != "n" ]; then
> > if [ "CONFIG_EXPERIMENTAL" = "y" ]; then
> > bool ' Enter S1 for sleep (EXPERIMENTAL)' CONFIG_ACPI_S1_SLEEP
>
> Even if it were an appropriate patch,
See above. The job's not done until it's documented!
> it is an incorrect one:
Note that I said ``SOMETHING LIKE.''
> you
> should test CONFIG_EXPERIMENTAL before even presenting an experimental
> option to the user.
Fair enough. However, since CONFIG_USB_UHCI_HIGH_BANDWIDTH in 2.3.48
and CONFIG_DM9102 in 2.2.14 do not follow this convention, I hope you
can understand why I might make such a mistake.
--Paul Vojta, vojta@math.berkeley.edu
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Tue Mar 07 2000 - 21:00:17 EST