On 4 Mar 2000, Jes Sorensen wrote:
> >>>>> "Jeff" == Jeff Garzik <jgarzik@mandrakesoft.com> writes:
>
> Jeff> Urg.... This is precisely what we are trying to move __away__
> Jeff> from in 2.3.x.
>
> Jeff> The code at the top should look like
>
> Jeff> #if old_kernel_version #define netif_running(dev) ... #endif
>
> Jeff> You should not be wrapping standard kernel functions as it only
> Jeff> serves to obscure the code.
>
> Jeff, there is nothing wrong with that patch. If you want to go on a
> crusade cleaning up this sort of stuff, then there are plent of other
> drivers where the entire driver has redefined everything. Yes it would
> be slightly cleaner to do it as say, but it's not exactly a big deal.
It's nice to be clean. But it's not right to push it up to an obsession :((
Does anybody care to fix sdla drivers? As I understand it was an imperative
to remove two members from wandrivers structs... We did spare 6 bytes per
each sdla card. It's very huge economy. It's even bigger than that, 'coz
wanpipe does not compile any more and we can spare not only that 6 bytes,
but all the memory which wanpipe driver used to occupy :((
===========================================================================
Sergey Kubushin aka the Tamer < > The impossible we do immediately.
e-mail: ksi@ksi-linux.com SK320-RIPE < > Miracles require 24-hour notice.
===========================================================================
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Tue Mar 07 2000 - 21:00:16 EST