Re: slip.c is not jiffy wrap proof in 2.2 and 2.3

From: Oleg Drokin (green@ccssu.crimea.ua)
Date: Wed Mar 01 2000 - 12:13:59 EST

Next message: Kevin Buhr: "Re: How to survive in a Micro$oft environment??"
Previous message: Peter T. Breuer: "Re: proconfig"
In reply to: Alan Cox: "Re: slip.c is not jiffy wrap proof in 2.2 and 2.3"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hello!

> > I found that drivers/net/slip.c in 2.2 and in 2.3 is not jiffy wrap proof.
> > it has this code 'if (jiffies - dev->trans_start < 20 * HZ) {'
> That seems wrap proof to me since both of the values are unsigned. In fact
> time_after is an inline of exactly this.
Inline casts everything to long, and there is a comment, that
urges everyone to use these inlines. And after all if this is
wrap proof, then why everybody else converted to these inlines?

Bye,
Oleg

-- 
 [RAVE *SUCKS* TEAM] [Team $Ui(iDE] [Trans-M Must Die!] [Sepultura Fans Team]
                         [Tolkien forever team]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

Next message: Kevin Buhr: "Re: How to survive in a Micro$oft environment??"
Previous message: Peter T. Breuer: "Re: proconfig"
In reply to: Alan Cox: "Re: slip.c is not jiffy wrap proof in 2.2 and 2.3"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Tue Mar 07 2000 - 21:00:10 EST