Re: 2.3.47 tulip lockup

From: Andrea Arcangeli (andrea@suse.de)
Date: Fri Feb 25 2000 - 09:28:40 EST


On Thu, 24 Feb 2000, Andre Hedrick wrote:

>> @@ -1009,6 +1003,9 @@
>> printk(KERN_INFO "%s: %s rev %d at %#3lx,",
>> dev->name, tulip_tbl[chip_idx].chip_name, chip_rev, ioaddr);
>>
>> + /* initalize before accessing the chipsets */
>> + spin_lock_init(&tp->tx_lock);
>> +
>
>Little overkill, prettier than my kludge, and looks like a decenct
>standard to setup "spin_lock_init(....);"

Note that such part is not the interesting part. It's not even necessary
right now to initialize the spinlock since the memset was just set it to
zero correctly also in stock 2.3.48pre1.

The interesting part is the interrupt code that was doing:

        interrupt()
        {
                spin_lock();
                spin_lock(); /* deadlock */

;)

Andrea

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Feb 29 2000 - 21:00:12 EST