Re: 2.3.45 -- Problem getting my PCMCIA modem to work.

From: Linus Torvalds (torvalds@transmeta.com)
Date: Mon Feb 14 2000 - 11:23:06 EST


On Mon, 14 Feb 2000, Miles Lane wrote:
>
> With 2.3.45 and Cardbus support built as a module, my keyboard and
> mouse work, even after I have run:

Yeehaa!

> When I insert my PCMCIA modem, the device is not recognized
> and I get "Cannot map memory" errors from card services.

This may be due to a truly astoundingly stupid buglet, which has been
there since 2.3.34, and which may account for a lot of silly problems with
some drivers.

Can you try applying the appended simple patch (three missing pointer
dereferences), and tell me if life is beautiful after that?

                Linus

----
diff -u --recursive --new-file v2.3.45/linux/drivers/pcmcia/cs.c linux/drivers/pcmcia/cs.c
--- v2.3.45/linux/drivers/pcmcia/cs.c	Thu Feb 10 17:11:12 2000
+++ linux/drivers/pcmcia/cs.c	Sun Feb 13 23:10:00 2000
@@ -2188,7 +2188,7 @@
     {
 	memory_handle_t m;
         int ret = pcmcia_open_memory(a1, a2, &m);
-        (memory_handle_t *)a1 = m;
+        *(memory_handle_t *)a1 = m;
 	return  ret;
     }
         break;
@@ -2202,7 +2202,7 @@
     {
 	eraseq_handle_t w;
         int ret = pcmcia_register_erase_queue(a1, a2, &w);
-        (eraseq_handle_t *)a1 = w;
+        *(eraseq_handle_t *)a1 = w;
 	return  ret;
     }
         break;
@@ -2227,7 +2227,7 @@
     {
 	window_handle_t w;
         int ret = pcmcia_request_window(a1, a2, &w);
-        (window_handle_t *)a1 = w;
+        *(window_handle_t *)a1 = w;
 	return  ret;
     }
         break;

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Feb 15 2000 - 21:00:27 EST