Re: Softnet/eepro100 driver conversion bug in 2.3.43pre8?

From: Jeff Garzik (jgarzik@mandrakesoft.com)
Date: Sun Feb 13 2000 - 12:53:17 EST


David Mosberger wrote:
>
> The following patch seems to fix the problem for me. I think the
> cmpxchg should be #ifdef'd on HAVE_CMPXCHG but in our experience,
> atomicity is important for updating cmd_status, so if you can't do
> this atomically, you're probably hosed anyhow (you'll get lots of Tx
> timeouts, at least).

Can you convert 'status' to atomic_t, and use the atomic_xxx API to
treat it as a truly atomic variable? When I looked at the code that's
what I thought about doing.

Regards,

        Jeff

-- 
Jeff Garzik         | "Vegetarian" is the Indian word
Building 1024       | for 'lousy hunter.'
MandrakeSoft, Inc.  |

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Feb 15 2000 - 21:00:25 EST