On Sun, Feb 13, 2000 at 01:54:31AM -0500, Alexander Viro wrote:
>
>
> On Thu, 10 Feb 2000 willy@thepuffingroup.com wrote:
>
> > + inode->i_rdev = device;
> > + inode->i_bdev = bdget(kdev_t_to_nr(device));
>
> Erm... Why not init_special_inode(inode, S_IFBLK|S_IRUSR, kdev_to_nr(device));
>
> > + out_inode->i_rdev = ram_device;
> > + out_inode->i_bdev = bdget(kdev_t_to_nr(ram_device));
>
> ... and similar here?
Agreed. I merged this part of B.D. Elliott's patch a couple of days ago.
(actually using S_IRWXU, but that's unimportant). I'm not terribly
happy about constructing the dentries and struct file either; is there
a better way of doing this?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Tue Feb 15 2000 - 21:00:24 EST