Re: [PATCH] isa_{read,write}{w,l} fixed

• Next message: Russell King: "Consistent PCI - API change needed"
• Previous message: Pavel Machek: "[PATCH] Re: Capabilities"
• In reply to: Martin Mares: "Re: [PATCH] isa_{read,write}{w,l} fixed"
• Next in thread: Russell King: "Re: [PATCH] isa_{read,write}{w,l} fixed"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Martin Mares wrote:
>
> Hello!
>
> > Using isa_xxx during init code is not a good idea because it encourages
> > assumptions which are not portable. isa_xxx just happens to work with
> > 32-bit PCI memory, for example, but (IIRC) it will not work on anywhere
> > but x86.
>
> isa_xxx functions should be available on all platforms supporting ISA,
> they are not i386 specific.

I meant that the x86-specific properties of isa_xxx was sometimes taken
advantage of, and this we should not encourage. like using isa_xxx to
address PCI MMIO regions (to avoid converting code fully to
ioremap/writeb), etc.

        Jeff

-- 
Jeff Garzik         | "Vegetarian" is the Indian word
Building 1024       | for 'lousy hunter.'
MandrakeSoft, Inc.  |
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Russell King: "Consistent PCI - API change needed"
• Previous message: Pavel Machek: "[PATCH] Re: Capabilities"
• In reply to: Martin Mares: "Re: [PATCH] isa_{read,write}{w,l} fixed"
• Next in thread: Russell King: "Re: [PATCH] isa_{read,write}{w,l} fixed"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Tue Feb 15 2000 - 21:00:22 EST