Re: Consistent PCI - API change needed

From: David S. Miller (davem@redhat.com)
Date: Fri Feb 11 2000 - 19:34:55 EST


   Date: Sat, 12 Feb 2000 00:33:05 +0000 (GMT)
   From: Alan Cox <alan@lxorguk.ukuu.org.uk>

> Can someone explain the purpose of this please?

   Its to ensure the pointer is aligned, it also ensures that if it wasnt
   then the kfree of the ring will crash the machine 8)

   Defining a minimum alignment for kmalloc at 16 bytes would be a big help

First, kmalloc is not used here. pci_alloc_consistent() is.

Secondly, it is freed via the "vp" pointer, so it should be ok.

Thirdly, yes pretty much we need to guarentee some sane minimal
alignment for pci_alloc_consistent() and this ugly line of code
can be removed.

Later,
David S. Miller
davem@redhat.com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Feb 15 2000 - 21:00:22 EST