Re: [PATCH] isa_{read,write}{w,l} fixed

From: Alan Cox (alan@lxorguk.ukuu.org.uk)
Date: Fri Feb 11 2000 - 09:11:07 EST


> I disagree. A lot of drivers seem to use structs as a cheap way to get
> separate namespaces for their readl() / sbus_readl() offsets, and inconsistent
> behaviour between readb() and isa_readb() (as well as isa_readb() on ARM
> and isa_reab() on x86) would be unnecessarily confusing.

I've fixed several drivers that do that. It doesnt work because structure
padding goes and bites the idiots who do this. Also a struct pointer isnt
capable of representing the entire physical address of some boxes - it can
hit the full ISA address space sure.

Alan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Feb 15 2000 - 21:00:20 EST