[patch:2.3.42] matroxfb: G400 non-/MAX distinction

From: Anton Altaparmakov (aia21@cus.cam.ac.uk)
Date: Sat Feb 05 2000 - 23:40:01 EST


Attached is a small patch against 2.3.42 which changes the matroxfb
driver to distinguish between the Matrox G400 MAX and non-MAX cards.

The patch sets maxclk to 300000 for non-MAX and 360000 for MAX cards.
Previously the value was 360000 for all G400, which IMVHO is wrong, since
according to the Matrox website only the MAX supports 360MHz, look at:
   http://www.matrox.com/mgaweb/products/comp_chart/g400_products.htm
I guess that 360MHz will work on non-max cards, however they might
overheat since AFAIK they are not supplied with a fan on the chip.
Feel free to correct me if I am wrong. (-;

The patch might not be generic enough, so it would be good to hear from
some people whether or not their G400MAX is correctly detected. - Having
said that, it works fine for me. (-:

During init the message for a G400 MAX will be:
        matroxfb: Millenium G400 MAX (AGP) detected
For a G400 non-MAX the message is (as before):
        matroxfb: unknown G400 (AGP) detected

Regards,

        Anton

-- 

"Programmers never die. They GOSUB without RETURN." - Unknown source

--

Anton Altaparmakov eMail: AntonA at bigfoot.com (replace " at " with @) WWW: http://tmd.ipfox.com/

--- original-2.3.42/drivers/video/matroxfb.c Fri Jan 7 00:17:19 2000 +++ linux/drivers/video/matroxfb.c Sun Feb 6 04:25:13 2000 @@ -63,6 +63,9 @@ * "Mark Vojkovich" <mvojkovi@ucsd.edu> * G400 support * + * "Anton Altaparmakov" <AntonA@bigfoot.com> + * G400 MAX/non-MAX distinction + * * (following author is not in any relation with this code, but his code * is included in this driver) * @@ -240,6 +243,7 @@ #define PCI_SS_ID_MATROX_MARVEL_G200_AGP 0xFF04 #define PCI_SS_ID_MATROX_MGA_G100_PCI 0xFF05 #define PCI_SS_ID_MATROX_MGA_G100_AGP 0x1001 +#define PCI_SS_ID_MATROX_MILLENIUM_G400_MAX_AGP 0x2179 #define PCI_SS_ID_SIEMENS_MGA_G100_AGP 0x001E /* 30 */ #define PCI_SS_ID_SIEMENS_MGA_G200_AGP 0x0032 /* 50 */ #endif @@ -5614,9 +5618,15 @@ &vbG200, "unknown G200 (AGP)"}, {PCI_VENDOR_ID_MATROX, PCI_DEVICE_ID_MATROX_G400_AGP, 0xFF, - 0, 0, + PCI_SS_VENDOR_ID_MATROX, PCI_SS_ID_MATROX_MILLENIUM_G400_MAX_AGP, DEVF_G400, 360000, + &vbG400, + "Millenium G400 MAX (AGP)"}, + {PCI_VENDOR_ID_MATROX, PCI_DEVICE_ID_MATROX_G400_AGP, 0xFF, + 0, 0, + DEVF_G400, + 300000, &vbG400, "unknown G400 (AGP)"}, #endif

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Feb 07 2000 - 21:00:13 EST