Re: [PATCH] 2.3.41-pre2 - cleanup file_operations structs

From: James Manning (jmm@raleigh.ibm.com)
Date: Mon Jan 24 2000 - 00:59:08 EST


[ Sunday, January 23, 2000 ] James Manning wrote:
> Several factors went into making this patch:
>
> - Chuck Lever's inspiration from his work which helped make vm_opertions
> structs name-assigned using gcc's initializer extension. (by necessity :)
> - Alsa possibly adding some file_operations struct members soon
> - future cache optimizations may well want to move around members
> so most commonly-access stay in the first cache line (or at least
> functions that tend to get called together are in the same line)
> - Lots of #ifdef's in code just to shove in an extra NULL depending
> on kernel version
> - Makes code more readable
> - Cuts down a large # of lines from the kernel

[snip]

I think it got eaten along the way to vger/funet/whatever
so I'll just put the url here:

http://sublogic.com/patches/file_operations.patch

Again, it's against 2.3.41-pre2

Feedback would be very welcome... inode_operations has an even larger
case than file_operations (same arguments) but I wanted some feedback
before tackling that one :)

James

-- 
Miscellaneous Engineer --- IBM Netfinity Performance Development

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Jan 31 2000 - 21:00:11 EST