Re: dst cache overflow

From: Andi Kleen (ak@muc.de)
Date: Thu Jan 13 2000 - 17:38:06 EST


On Thu, Jan 13, 2000 at 08:36:49PM +0100, kuznet@ms2.inr.ac.ru wrote:
> Hello!
>
> > - if (tcp_close_state(sk,0))
> > + if (tcp_close_state(sk,sk->state == TCP_CLOSE_WAIT))
>
> I apologize, it will not break anyone, because it is noop.
> Socket cannot go to FIN-WAIT-2 from CLOSE-WAIT in any case.

FIN-WAIT-2?

I saw LAST-ACK sockets in the thread and I looked for them.

Please explain why you think it is a noop. I did not find any
check preventing a shutdown on a close-wait socket, and it would
end in a last-ack socket with timers off.

Now if there were fin-wait-2 and other sockets with no timers too
that would be another bug.

-Andi

-- 
This is like TV. I don't like TV.

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Jan 15 2000 - 21:00:23 EST