Suspicious code in uid16?

From: Pauline Middelink (middelink@polyware.nl)
Date: Tue Jan 11 2000 - 14:47:10 EST


LS,

Just looked over the uid16.c file, functions sys_getgroup16()
and sys_setgroup16().

Every function correctly uses the high2lowgid and low2highgid
stuff correctly, except those 2. I presume the array we read
/write from user space contains 16 bits gids, so they must
be converted to 32 bit gids, yes?

I'm also puzzled by the sys_setuid16() and sys_setgid16() functions,
but I assume the high/low functions are not needed here, since
the -1 value has no special meaning here?

Hmmm, come to think of it, the group function have probably the
same reasoning?

    Met vriendelijke groet,
        Pauline Middelink

-- 
PGP Key fingerprint = DE 6B D0 D9 19 AD A7 A0  58 A3 06 9D B6 34 39 E2
For more details look at my website http://www.polyware.nl/~middelink

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Jan 15 2000 - 21:00:18 EST